GH-49948: [CI][C++] Revert PR 49931 (Pin MinGW MSYS2 packages) but keep bumped minIO version#49945
Conversation
tadeja
force-pushed
the
revert-pins-from-49931
branch
from
4f1af1b to
4c7390f
Compare
tadeja
force-pushed
the
revert-pins-from-49931
branch
from
4c7390f to
cb652aa
Compare
tadeja
changed the title
|
|
tadeja
force-pushed
the
revert-pins-from-49931
branch
from
b31db22 to
cb652aa
Compare
|
See updated #49948 and #49958, ready to revert pinned package versions with this PR! GCC 125312 related fix already merged in upstream MSYS2 - |
tadeja
force-pushed
the
revert-pins-from-49931
branch
from
cb652aa to
0e22776
Compare
rok
left a comment
rok
left a comment
There was a problem hiding this comment.
I've followed the upstream development and this makes sense to me. Will merge if CI green.
github-actions
Bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 27513af. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…but keep bumped minIO version (apache#49945) ### Rationale for this change Ready to revert pinned packages on MINGW64 with tests all passing now - see updated umbrella issue apache#49948 and apache#49958. Past origin PR discussion apache#49931 (review) ### What changes are included in this PR? Reverting PR apache#49931's temporary pins workaround - so completely removing step ` - name: Setup MSYS2`. ### Are these changes tested? Yes, tests now pass on current upstream MSYS2 ### Are there any user-facing changes? No. * GitHub Issue: apache#49948 Authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com> Signed-off-by: Rok Mihevc <rok@mihevc.org>
3 participants
Rationale for this change
Ready to revert pinned packages on MINGW64 with tests all passing now - see updated umbrella issue #49948 and #49958.
Past origin PR discussion #49931 (review)
What changes are included in this PR?
Reverting PR #49931's temporary pins workaround - so completely removing step
- name: Pin MSYS2 packages.Are these changes tested?
Yes, tests now pass on current upstream MSYS2
Are there any user-facing changes?
No.